search

thoth-station / adviser

The recommendation engine for Python software stacks and Dependency Monkey in project Thoth.
https://thoth-station.github.io
GNU General Public License v3.0
34 stars 13 forks source link

Remove setup.cfg #2421

Open VannTen opened 1 year ago

VannTen commented 1 year ago

Revert workaround introduced in 6bf28d50ae4efb22abc8e2eae359d6b28e58f58b once s2i base image properly detect pyproject.toml /kind cleanup

VannTen commented 1 year ago

/sig stack-guidance /priority backlog /good-first-issue

sesheta commented 1 year ago

@VannTen: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/thoth-station/adviser/issues/2421): >/sig stack-guidance >/priority backlog >/good-first-issue > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ishan301 commented 1 year ago

Hi, I am a new contributor and I would like to contribute to this project. So, I just need to remove the setup.cfg file and raise a PR right?

VannTen commented 1 year ago

Yes. But as noted this currently does not work with our base s2i image, so we'll only change it once that's resolved.