Use thoth-s2i image as a default value in api schema

thoth-station / amun-api

Thoth's execution engine for inspecting quality, performance, and usability of software and software stacks in a cluster.

https://thoth-station.ninja/

GNU General Public License v3.0

8 stars 13 forks source link

Use thoth-s2i image as a default value in api schema #662

Closed mayaCostantini closed 2 years ago

mayaCostantini commented 2 years ago

Related Issues and Dependencies

This introduces a breaking change

This Pull Request implements

Use the s2i-thoth-ubi8-py38 base image as a default value in the /inspect endpoint. The current default value registry.access.redhat.com/ubi8/python-36 does not have pipenv or micropipenv available, and as @fridex mentioned it would be better to use our own containerized environment to see how packages behave in them.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/amun-api/blob/master/OWNERS)~~ [fridex] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment