search

thoth-station / analyzer

Analyzer library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
0 stars 10 forks source link

Does this repo need `.aicoe-ci.yaml`? #292

Closed bissenbay closed 3 years ago

bissenbay commented 3 years ago

Related-To: https://github.com/thoth-station/thoth-application/issues/545#issuecomment-735908736

harshad16 commented 3 years ago

@bissenbay , As explained in this issue: https://github.com/thoth-station/build-watcher/issues/177#issuecomment-734702140, all application that we are porting to python38 needs the addition of .aicoe-ci.yaml , reasons:

as the default pipeline behavior is to run on python36 image, so earlier it was not needed. however, if an app is changed to python 38 it needs the file.

now about the files, applications like, storages, common, lab, analyzer which are python package modules. They don't need container images separately. only need a release to pypi. so please based on the application please see if they have pytest, pre-commit requirements, accordingly adjust the following:

check:
  - thoth-pytest-py38
  - thoth-precommit
release:
  - upload-pypi-sesheta

please do this for all the repository, we are porting to python 38. you can mark me as the reviewer.

harshad16 commented 3 years ago

/assign @bissenbay

bissenbay commented 3 years ago

@bissenbay , As explained in this issue: thoth-station/build-watcher#177 (comment), all application that we are porting to python38 needs the addition of .aicoe-ci.yaml , reasons:

  • builds needs python38 based images
  • pytest needs python38 based images

as the default pipeline behavior is to run on python36 image, so earlier it was not needed. however, if an app is changed to python 38 it needs the file.

now about the files, applications like, storages, common, lab, analyzer which are python package modules. They don't need container images separately. only need a release to pypi. so please based on the application please see if they have pytest, pre-commit requirements, accordingly adjust the following:

check:
  - thoth-pytest-py38
  - thoth-precommit
release:
  - upload-pypi-sesheta

please do this for all the repository, we are porting to python 38. you can mark me as the reviewer.

thanks @harshad16 for the detailed explanation