search

thoth-station / analyzer

Analyzer library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
0 stars 10 forks source link

Migrate to pyproject.toml #311

Closed VannTen closed 2 years ago

VannTen commented 2 years ago

Translate setup.py into a pyproject.toml file

/kind feature /triage accepted /sig stack-guidance /good-first-issue /label hacktoberfest

Parent issue: https://github.com/thoth-station/core/issues/360

sesheta commented 2 years ago

@VannTen: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/thoth-station/analyzer/issues/311): >Translate setup.py into a pyproject.toml file > >/kind feature >/triage accepted >/sig stack-guidance >/good-first-issue >/label hacktoberfest > >Parent issue: https://github.com/thoth-station/core/issues/360 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ChandanChainani commented 2 years ago

Hi @sesheta can i work on the issue?

VannTen commented 2 years ago

Go for it ! :+1:

ChandanChainani commented 2 years ago

@sesheta @VannTen

What's the use of below option? https://github.com/thoth-station/analyzer/blob/1dc9de88a01fffdf5185f8caf8b522abbc49ef70/setup.py#L42-L47

Below option can be written with the help of dynamic-metadata in pyproject.toml but this feature is in beta phase and it may change as pointed here https://github.com/thoth-station/analyzer/blob/1dc9de88a01fffdf5185f8caf8b522abbc49ef70/setup.py#L37-L41

Can we write minimum config in pyproject.toml and the rest in setup.cfg?

VannTen commented 2 years ago

On Fri, Oct 07, 2022 at 11:46:17AM -0700, ChandanChainani wrote:

@sesheta @VannTen

What's the use of below option? https://github.com/thoth-station/analyzer/blob/1dc9de88a01fffdf5185f8caf8b522abbc49ef70/setup.py#L42-L47

This is sphinx integration, see https://www.sphinx-doc.org/pl/master/usage/advanced/setuptools.html

Below option can be written with the help of dynamic-metadata in pyproject.toml but this feature is in beta phase and it may change as pointed here https://github.com/thoth-station/analyzer/blob/1dc9de88a01fffdf5185f8caf8b522abbc49ef70/setup.py#L37-L41

Can we write minimum config in pyproject.toml and the rest in setup.cfg?

No problem to use the beta dynamic-metadata support ; setup.cfg is probably needed for sphinx though, there is not support for having it directly in pyproject.toml yet AFAIK.