search

thoth-station / common

A common library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
4 stars 19 forks source link

Add types-requests to the dev dependencies #1170

Closed fridex closed 3 years ago

fridex commented 3 years ago

Related Issues and Dependencies

Related: https://github.com/thoth-station/common/pull/1168#issuecomment-859316285

This introduces a breaking change

fridex commented 3 years ago

@fridex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command aicoe-ci/prow/pytest 79fc5c6 link /test thoth-pytest-py38 Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

CC @goern @harshad16 cannot expand logs here. Any suggestion?

goern commented 3 years ago

hmm, right, expanding the build log on the HTML pages sometimes takes a lot of time, esp if its 11k lines, looking at the raw log might be easier/faster, but... http://s3.openshift-storage.svc.cluster.local/ci-prow-artifacts--024cd900-706c-488d-afb0-d28522131f45/prow-logs/pr-logs/pull/thoth-station_common/1170/thoth-pytest-py38/1403243549025112064/build-log.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=mM8HzDK82lqAtKapmwca%2F20210611%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20210611T070329Z&X-Amz-Expires=600&X-Amz-SignedHeaders=host&X-Amz-Signature=0fceafda8995a3a46748c48e238296f48d307082d0a56d41387a872fab826344

@harshad16 I think Prow is putting the wrong URL in for the S3 storage?!

goern commented 3 years ago

/approve

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: goern To complete the pull request process, please ask for approval from fridex after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshad16 commented 3 years ago

/test thoth-pytest-py38

harshad16 commented 3 years ago

I think Prow is putting the wrong URL in for the S3 storage?!

The prow link keeps showing the last iteration till the new iteration takes over. The link would be of the previously run execution, as soon as newer execution get done , it is update. is there some other reason you feel, it is showing wrong value.

sesheta commented 3 years ago

@fridex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
aicoe-ci/prow/pytest 79fc5c6add8aeda8f108eeb974632a05aabbd8e2 link /test thoth-pytest-py38

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
harshad16 commented 3 years ago

/test thoth-pytest-py38

sesheta commented 3 years ago

@harshad16: No presubmit jobs available for thoth-station/common@master

In response to [this](https://github.com/thoth-station/common/pull/1170#issuecomment-864971500): >/test thoth-pytest-py38 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sesheta commented 3 years ago

@fridex: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
harshad16 commented 3 years ago

we can close this PR the types-requests required for mypy error fix was fixed by updating the mypy.ini config by PR #1173 this update is not needed anymore. @fridex

fridex commented 3 years ago

we can close this PR the types-requests required for mypy error fix was fixed by updating the mypy.ini config by PR #1173 this update is not needed anymore. @fridex

Sounds good. Thanks. 👍🏻

/close

sesheta commented 3 years ago

@fridex: Closed this PR.

In response to [this](https://github.com/thoth-station/common/pull/1170#issuecomment-864976104): >> we can close this PR >> the types-requests required for mypy error fix was fixed by updating the mypy.ini config by PR #1173 >> this update is not needed anymore. @fridex > >Sounds good. Thanks. 👍🏻 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.