Add repository name to the scheduled mi workflows - Githubissues

thoth-station / common

A common library for the Thoth project

https://thoth-station.github.io/

GNU General Public License v3.0

4 stars 19 forks source link

Add repository name to the scheduled mi workflows #1191

Closed xtuchyna closed 2 years ago

xtuchyna commented 3 years ago

Is your feature request related to a problem? Please describe. Hello! Currently, the mi workflows are scheduled with names as follows:

mi-analysis-mi-210715120822-ab98e5f26d2b4148   Pending   2h    0s         0
mi-analysis-mi-210715120822-b2b1cee430cca8e7   Pending   2h    0s         0
mi-analysis-mi-210715120821-7feec52461ef063d   Pending   2h    0s         0
mi-analysis-mi-210715120821-94fdbb46715585e7   Pending   2h    0s         0
mi-analysis-mi-210715120821-9aacbfe9bc0e92bc   Pending   2h    0s         0
mi-analysis-mi-210715120821-bc902f486165a4dd   Pending   2h    0s         0
mi-analysis-mi-210715120821-cd7c7ecadd842c83   Pending   2h    0s         0

Which is fine, but is really not that informative. Better naming convention would contain repository name (and maybe appended entities that are being inspected?! but that's another step).

Describe the solution you'd like instead of mi-analysis-mi-{ID} have something like

mi-analysis-{repo_name}-{ID}

or even

mi-analysis-{repo_name}-{entities}-{ID}

where entities is substitued by { <entity_name> }⁺ . { _ . <entity_name> }* as in ebnf-styled grammar

Use case If workflow fails, maintainer does not have to look into logs what repository failed specifically

goern commented 3 years ago

/priority important-soon

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 3 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/common/issues/1191#issuecomment-904446206): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

xtuchyna commented 3 years ago

/reopen /remove-lifecycle rotten

sesheta commented 3 years ago

@xtuchyna: Reopened this issue.

In response to [this](https://github.com/thoth-station/common/issues/1191#issuecomment-943242257): >/reopen >/remove-lifecycle rotten Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

xtuchyna commented 3 years ago

/priority-important soon

sesheta commented 3 years ago

@xtuchyna: The label(s) priority/soon cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/thoth-station/common/issues/1191#issuecomment-943242357): >/priority-important soon Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 2 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 2 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/common/issues/1191#issuecomment-1066109712): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.