search

thoth-station / common

A common library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
4 stars 19 forks source link

Initialize platform to a default, supported value #1196

Closed fridex closed 2 years ago

fridex commented 2 years ago

Related Issues and Dependencies

Related: https://github.com/thoth-station/adviser/pull/2171

This introduces a breaking change

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from fridex after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fridex commented 2 years ago

/hold

Testing. It might be that the implementation will land in adviser to have this more generic.

sesheta commented 2 years ago

@fridex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit f62142c4823aaa6e1cd78f3ee234c9726bfeb1dd link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
fridex commented 2 years ago

/hold

Testing. It might be that the implementation will land in adviser to have this more generic.

Let's be platform-agnostic here.

/close

sesheta commented 2 years ago

@fridex: Closed this PR.

In response to [this](https://github.com/thoth-station/common/pull/1196#issuecomment-978230346): >> /hold >> >> Testing. It might be that the implementation will land in adviser to have this more generic. > >Let's be platform-agnostic here. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.