search

thoth-station / common

A common library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
4 stars 19 forks source link

Update workflows.py #1223

Closed peremoar closed 2 years ago

peremoar commented 2 years ago

From v4.0.0, __init__.py file of argo-client-python is empty. For this reason, the import should be now:

from argo.workflows.client import models instead of:

from argo.workflows import models Other versions of the client (as this one) keeps the older content of the __init__.py.

The change doesn't produces backward incompatibilities to users with the non-empty version of the __init__.py

Related Issues and Dependencies

…

This introduces a breaking change

This Pull Request implements

… Explain your changes.

Description

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign sesheta after the PR has been reviewed. You can assign the PR to them by writing /assign @sesheta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

Hi @peremoar. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fridex commented 2 years ago

Thanks, @peremoar for your pull-request. We pin argo-workflows to <4 and there are no plans to update to a more recent version. We would like to migrate to hera-workflows (see https://github.com/thoth-station/common/issues/1219), which is more likely an alternative and update to the codebase.

Thanks again for your pull request and your interest. I will close it as the codebase will require a new library.

/close

sesheta commented 2 years ago

@fridex: Closed this PR.

In response to [this](https://github.com/thoth-station/common/pull/1223#issuecomment-1031807906): >Thanks, @peremoar for your pull-request. We [pin argo-workflows to `<4`](https://github.com/thoth-station/common/blob/13e47c8df393f9fe68a8827b02fcd63e207f0411/Pipfile#L8) and there are no plans to update to a more recent version. We would like to migrate to hera-workflows (see https://github.com/thoth-station/common/issues/1219), which is more likely an alternative and update to the codebase. > >Thanks again for your pull request and your interest. I will close it as the codebase will require a new library. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.