Closed peremoar closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign sesheta after the PR has been reviewed.
You can assign the PR to them by writing /assign @sesheta
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @peremoar. Thanks for your PR.
I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Thanks, @peremoar for your pull-request. We pin argo-workflows to <4
and there are no plans to update to a more recent version. We would like to migrate to hera-workflows (see https://github.com/thoth-station/common/issues/1219), which is more likely an alternative and update to the codebase.
Thanks again for your pull request and your interest. I will close it as the codebase will require a new library.
/close
@fridex: Closed this PR.
From v4.0.0, __init__.py file of argo-client-python is empty. For this reason, the import should be now:
from argo.workflows.client import models
instead of:from argo.workflows import models
Other versions of the client (as this one) keeps the older content of the __init__.py.The change doesn't produces backward incompatibilities to users with the non-empty version of the __init__.py
Related Issues and Dependencies
…
This introduces a breaking change
This Pull Request implements
… Explain your changes.
Description