search

thoth-station / common

A common library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
4 stars 19 forks source link

Send messages based on template defaults, do not hardcode #1231

Closed fridex closed 2 years ago

fridex commented 2 years ago

Related Issues and Dependencies

We should not hardcode this behavior, rather have it configurable on the template level.

fridex commented 2 years ago

/assign @har

sesheta commented 2 years ago

@fridex: GitHub didn't allow me to assign the following users: har.

Note that only thoth-station members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/thoth-station/common/pull/1231#issuecomment-1062087066): >/assign @har Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fridex commented 2 years ago

/assign @harshad16

harshad16 commented 2 years ago

/assign @fridex

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16, KPostOffice To complete the pull request process, please ask for approval from fridex after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/common/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment