Add mypy back to pre-commit

thoth-station / common

A common library for the Thoth project

https://thoth-station.github.io/

GNU General Public License v3.0

4 stars 19 forks source link

Add mypy back to pre-commit #1275

Closed xtuchyna closed 1 year ago

xtuchyna commented 1 year ago

Related Issues and Dependencies

Closes https://github.com/thoth-station/common/issues/1252

This introduces a breaking change

[ ] Yes
[X] No

Description

SSIA

xtuchyna commented 1 year ago

This should pass pre-commit, basically fixed some type hints to be more ambiguous and some to be ignored, locked attrs module to a v22.1.0 and added it as an additional dependency specifically in mypy.ini config file (this actually fixes mypy errors complaining there are no type stubs installed for attrs module)

xtuchyna commented 1 year ago

/cc @harshad16

xtuchyna commented 1 year ago

/cc @goern

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/common/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment