search

thoth-station / common

A common library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
4 stars 19 forks source link

Migrate to pyproject.toml #1287

Closed VannTen closed 2 years ago

VannTen commented 2 years ago

Translate setup.py into a pyproject.toml file

/kind feature /triage accepted /sig stack-guidance /good-first-issue /label hacktoberfest

Parent issue: https://github.com/thoth-station/core/issues/360

sesheta commented 2 years ago

@VannTen: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/thoth-station/common/issues/1287): >Translate setup.py into a pyproject.toml file > >/kind feature >/triage accepted >/sig stack-guidance >/good-first-issue >/label hacktoberfest > >Parent issue: https://github.com/thoth-station/core/issues/360 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
theyashl commented 2 years ago

Hi @VannTen , I have raised the MR with required changes, can you please have a look and let me know if any changes are required?

ChandanChainani commented 2 years ago

@harshad16 since the pr is merged please can you close the issue

harshad16 commented 2 years ago

Thank you @theyashl and @ChandanChainani for the PR and for the contributions. awesome work :100: