search

thoth-station / common

A common library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
4 stars 19 forks source link

Moved setup.py to pyproject.toml #1289

Closed theyashl closed 1 year ago

theyashl commented 1 year ago

Related Issues and Dependencies

https://github.com/thoth-station/common/issues/1287

This introduces a breaking change

This Pull Request implements

Implemented pyproject.toml and removed dependency of setup.py

Description

Create pyproject.toml file to keep track of project metadata. Removed setup.py file as it is in-neccessary after pyproject.toml file. Create setup.cfg file to add sphinx integration as it's support is not available in pyproject.toml. ref: https://github.com/thoth-station/analyzer/issues/311#issuecomment-1272891885

sesheta commented 1 year ago

Hi @theyashl. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
VannTen commented 1 year ago

/ok-to-test

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/common/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment