search

thoth-station / common

A common library for the Thoth project
https://thoth-station.github.io/
GNU General Public License v3.0
4 stars 19 forks source link

Make workflows names lowercase [mi-scheduler] #1294

Closed xtuchyna closed 1 year ago

xtuchyna commented 1 year ago

Related Issues and Dependencies

Related to https://github.com/thoth-station/mi-scheduler/issues/249

This introduces a breaking change

Description

In addition to underscores, uppercase letters are also not allowed for workflow names

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/common/blob/master/OWNERS)~~ [mayaCostantini] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xtuchyna commented 1 year ago

/lgtm

sesheta commented 1 year ago

@xtuchyna: you cannot LGTM your own PR.

In response to [this](https://github.com/thoth-station/common/pull/1294#issuecomment-1296934032): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xtuchyna commented 1 year ago

hello @mayaCostantini can you please also add /lgtm ?

mayaCostantini commented 1 year ago

/lgtm