thoth-station / dependency-monkey

The "Dependency Monkey" is a service for validating of package dependencies within an application stack.
GNU General Public License v3.0
2 stars 4 forks source link

setup.py should include requirements from Pipenv or requirements.txt file #8

Closed goern closed 4 years ago

goern commented 6 years ago

Right now there is a fixed list of requirements within setup.py, thats not that clever.

ace2107 commented 6 years ago

Reading from Pipfile or Pipfile.lock is not a good idea and shouldn't be done. On the other hand some overlapping between requirements and setup is possible , it is not recommended .

https://stackoverflow.com/questions/14399534/reference-requirements-txt-for-the-install-requires-kwarg-in-setuptools-setup-py

ace2107 commented 6 years ago

Though something like this can be a solution . https://github.com/elgertam/cookiecutter-pypackage/blob/master/%7B%7Bcookiecutter.project_slug%7D%7D/setup.py