search

thoth-station / graph-sync-job

Job for syncing data from object store to a graph database
https://thoth-station.github.io/
GNU General Public License v3.0
2 stars 10 forks source link

Update documentation regarding the CronJob #648

Closed Gregory-Pereira closed 1 year ago

Gregory-Pereira commented 2 years ago

As a part of improving the migration of the Thoth graph database between staging and prod, I have been following this PR which randomizes adviser document IDs, allowing for multiple jobs to be run in parallel. After this PR has been completed, the version for the thoth.storages should be bumped in thoth-station/sync-job repo (not this one). However after that, it will need to be converted into a Cronjob, which can run in Openshift. I was reading through the documentation in this repository to figure out how to do that, and if the resource for the graph-sync-job was available or constructed here. Instead, I found documentation telling me to look for the openshift/ solver in the root of this repository for the Cronjob, however it appears that this has been deprecated. We should clarify this in the documentation and potentially point to our procedure for constructing new CronJobs.

/cc @harshad16

fridex commented 2 years ago

All the deployment manifests live in the thoth-station/thoth-application repository. I think we forgot to reflect this fact in docs.

goern commented 2 years ago

/sig devsecops /priority important-soon /kind doc /kind feature

sesheta commented 2 years ago

@goern: The label(s) kind/doc cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/thoth-station/graph-sync-job/issues/648#issuecomment-1114753460): >/sig devsecops >/priority important-soon >/kind doc >/kind feature Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

goern commented 2 years ago

ping

harshad16 commented 2 years ago

/remove-lifecycle stale /lifecycle frozen