Functional tests for the pipelines

thoth-station / helm-charts

A Place for our Helm Charts

https://thoth-station.github.io/helm-charts/

GNU General Public License v3.0

0 stars 7 forks source link

Functional tests for the pipelines #30

Closed codificat closed 2 years ago

codificat commented 2 years ago

Problem statement

There are no functional tests for the pipelines in the charts.

As a user of the helm charts, I would like to have automated tests that ensure that the pipelines deployed by the charts are and remain functional, so that I can have confidence that they will work when installed.

High-level Goals

There should be functional tests available for the pipelines in the repo.

Proposal description

Alternatives

No functional testing.

Additional context

At this time, there is a GitHub Actions workflow that uses the chart-testing tool to lint and test that the chart installs correctly. However, it does not perform any kind of functional test, other than ensuring that a helm install will succeed and the related pods (e.g. the event listener) start up correctly.

Acceptance Criteria

[ ] there are a set of tests defined that verify a minimum of functionality for the pipelines
[ ] tests are run on every PR to ensure that these functional tests pass

codificat commented 2 years ago

Examplesof what could/should be avoided thanks to the tests are (parts of) #28 and #29: the fact that freshly installed charts come with references to non-existing trigger templates or bindings

codificat commented 2 years ago

/triage accepted /priority important-soon

codificat commented 2 years ago

/sig devsecops

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 2 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 2 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/helm-charts/issues/30#issuecomment-1221480567): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.