search

thoth-station / init-job

Thoth's initialization job that automatically initializes a fresh deployment
GNU General Public License v3.0
1 stars 7 forks source link

allow other list of packages to be solved #426

Closed harshad16 closed 3 years ago

harshad16 commented 3 years ago

allow other list of packages to be solved Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: https://github.com/thoth-station/thoth-application/issues/1764

Copied from https://raw.githubusercontent.com/fridex/devnull/master/rhods_nb_packages.txt https://raw.githubusercontent.com/fridex/devnull/master/ray_pkgs.txt credit-to: @fridex

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign sesheta after the PR has been reviewed. You can assign the PR to them by writing /assign @sesheta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/init-job/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
goern commented 3 years ago

/lgtm

fridex commented 3 years ago

Thanks for working on this, but I'm not sure about this change. Can we keep just a list of packages that the system is supposed to be initialized with?

See this comment and discussion https://github.com/thoth-station/thoth-application/issues/1763#issuecomment-870345028

harshad16 commented 3 years ago

Thanks for working on this, but I'm not sure about this change. Can we keep just a list of packages that the system is supposed to be initialized with?

yes, @fridex we would separate that on the deployment side For this pr, the goal, is to have all this list available in init-job for future. if there is to be thoth deployment in the rhods cluster, then this would be beneficial was my thought.

fridex commented 3 years ago

Thanks for working on this, but I'm not sure about this change. Can we keep just a list of packages that the system is supposed to be initialized with?

yes, @fridex we would separate that on the deployment side For this pr, the goal, is to have all this list available in init-job for future. if there is to be thoth deployment in the rhods cluster, then this would be beneficial was my thought.

I'm not sure if this is something we want to maintain and support. My point is how the system is initialized - the initialization should be agnostic to any consumer. In other words, it is ok if we maintain a list of packages that should be used for initialization, the fact they are RHODS/Ray specific is a detail that should not go to sources or deployment templates. From Thoth point of view, it should be just "initialize the system with the given set of packages".

harshad16 commented 3 years ago

I'm not sure if this is something we want to maintain and support. My point is how the system is initialized - the initialization should be agnostic to any consumer. In other words, it is ok if we maintain a list of packages that should be used for initialization, the fact they are RHODS/Ray specific is a detail that should not go to sources or deployment templates. From Thoth point of view, it should be just "initialize the system with the given set of packages".

very valid point. initialization should be agnostic of customer thanks for the comment.