search

thoth-station / integration-tests

Integration tests for the Thoth project to make sure deployment works as expected
GNU General Public License v3.0
4 stars 12 forks source link

Test strict index configuration #354

Closed mayaCostantini closed 1 year ago

mayaCostantini commented 1 year ago

Related Issues and Dependencies

Related to https://github.com/thoth-station/integration-tests/issues/240

This introduces a breaking change

This Pull Request implements

Test advise with strict index configuration.

mayaCostantini commented 1 year ago

/hold It seems like adviser has some issues resolving the stack for recent version of tensorflow in this environment. I need to look into a more recent database dump if we have the right versions ingested for the advise to succeed.

mayaCostantini commented 1 year ago

/unhold

mayaCostantini commented 1 year ago

Tested against prod deployment, ready for review.

KPostOffice commented 1 year ago

/lgtm

goern commented 1 year ago

/approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/integration-tests/blob/main/OWNERS)~~ [goern] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment