search

thoth-station / jupyter-nbrequirements

Dependency management and optimization in Jupyter Notebooks
MIT License
20 stars 6 forks source link

Adjust recommendation type and reviewers #280

Closed pacospace closed 3 years ago

pacospace commented 3 years ago

Signed-off-by: Francesco Murdaca fmurdaca@redhat.com

Fixes: https://github.com/thoth-station/jupyter-nbrequirements/issues/277

sesheta commented 3 years ago
Pytest Test failed! Click here ``` running test Searching for setuptools>=40.3.0 Reading https://pypi.org/simple/setuptools/ Downloading https://files.pythonhosted.org/packages/6d/38/c21ef5034684ffc0412deefbb07d66678332290c14bb5269c85145fbd55e/setuptools-50.3.2-py3-none-any.whl#sha256=2c242a0856fbad7efbe560df4a7add9324f340cf48df43651e9604924466794a Best match: setuptools 50.3.2 Processing setuptools-50.3.2-py3-none-any.whl Installing setuptools-50.3.2-py3-none-any.whl to /workspace/repo/.eggs writing requirements to /workspace/repo/.eggs/setuptools-50.3.2-py3.6.egg/EGG-INFO/requires.txt Installed /workspace/repo/.eggs/setuptools-50.3.2-py3.6.egg running egg_info creating jupyter_nbrequirements.egg-info writing jupyter_nbrequirements.egg-info/PKG-INFO writing dependency_links to jupyter_nbrequirements.egg-info/dependency_links.txt writing requirements to jupyter_nbrequirements.egg-info/requires.txt writing top-level names to jupyter_nbrequirements.egg-info/top_level.txt writing manifest file 'jupyter_nbrequirements.egg-info/SOURCES.txt' reading manifest file 'jupyter_nbrequirements.egg-info/SOURCES.txt' reading manifest template 'MANIFEST.in' warning: no files found matching 'CHANGELOG.md' writing manifest file 'jupyter_nbrequirements.egg-info/SOURCES.txt' running build_ext Jupyter Require found itself running outside of Jupyter. jupyter_nbrequirements (unittest.loader._FailedTest) ... ERROR ====================================================================== ERROR: jupyter_nbrequirements (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: jupyter_nbrequirements Traceback (most recent call last): File "/usr/lib64/python3.6/unittest/loader.py", line 462, in _find_test_path package = self._get_module_from_name(name) File "/usr/lib64/python3.6/unittest/loader.py", line 369, in _get_module_from_name __import__(name) File "/workspace/repo/jupyter_nbrequirements/__init__.py", line 38, in from jupyter_require import execute as executejs File "/opt/app-root/lib/python3.6/site-packages/jupyter_require/__init__.py", line 34, in from .notebook import link_css File "/opt/app-root/lib/python3.6/site-packages/jupyter_require/notebook.py", line 30, in from .core import execute_with_requirements File "/opt/app-root/lib/python3.6/site-packages/jupyter_require/core.py", line 279, in require = RequireJS() File "/opt/app-root/lib/python3.6/site-packages/jupyter_require/core.py", line 90, in __new__ raise EnvironmentError(msg) OSError: Jupyter Require found itself running outside of Jupyter. ---------------------------------------------------------------------- Ran 1 test in 0.000s FAILED (errors=1) Test failed: error: Test failed: ```
sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/jupyter-nbrequirements/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment