thoth-station / jupyterlab-requirements

JupyterLab Extension for dependency management and optimization
GNU General Public License v3.0
16 stars 9 forks source link

Added dropdown menus #608

Closed Gkrumbach07 closed 2 years ago

Gkrumbach07 commented 2 years ago

Related Issues and Dependencies

https://github.com/thoth-station/jupyterlab-requirements/issues/63

This introduces a breaking change

This Pull Request implements

Gkrumbach07 commented 2 years ago

pre-commit fails on black-nb. I found in one other recent (less than a day) issue that someone had the same problem. I believe the latest version on black-nb is causing the error. Also this commit has no py files.

pacospace commented 2 years ago

pre-commit fails on black-nb. I found in one other recent (less than a day) issue that someone had the same problem. I believe the latest version on black-nb is causing the error. Also this commit has no py files.

I see this also beside black issue

[INFO] Installing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook
Fixing src/components/dependencyManagementConstraintPicker.tsx
Fixing style/icons/info.svg
pacospace commented 2 years ago

pre-commit fails on black-nb. I found in one other recent (less than a day) issue that someone had the same problem. I believe the latest version on black-nb is causing the error. Also this commit has no py files.

cc @harshad16 have you seen that problem already? do we need to update the base image for pre-commit for prow?

pacospace commented 2 years ago

hey @Gkrumbach07 can you try modifying the .prow.yaml and use v0.14.3 in https://github.com/thoth-station/jupyterlab-requirements/blob/024e441b3c4947dbf4df8900120fadde38644cc1/.prow.yaml#L9?

harshad16 commented 2 years ago

have you seen that problem already? do we need to update the base image for pre-commit for prow?

I m trying to check on this issue and try to find the issue based on the investigation.

pacospace commented 2 years ago

Thanks @harshad16 for fixing it! @Gkrumbach07 can you please rebase on the merge PR fixing pre-commit?

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/jupyterlab-requirements/blob/master/OWNERS)~~ [pacospace] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment