Gkrumbach07
commented
2 years ago /assign @Gkrumbach07 /lifecycle active
Closed Gkrumbach07 closed 2 years ago
Gkrumbach07
commented
2 years ago /assign @Gkrumbach07 /lifecycle active
Gkrumbach07
commented
2 years ago /close
sesheta
commented
2 years ago @Gkrumbach07: Closing this issue.
Is your feature request related to a problem? Please describe. When removing pipenv as an option, users should be notified if a package is not known by Thoth
Describe the solution you'd like As a data scientist, I want to use jupyterlab-requirements dependency manager to help me manage my notebook dependencies. I am using mostly common packages except for a specific graphing package. When adding my packages to the dependency manager form, I am told that my graphing package does not exist despite it working in my own environment.
The user has added a package not ingested by Thoth, therefore we cannot resolve the users dependencies.
In a future release, Pipenv resolving will no longer be an option. Therefore the autocomplete feature will only pull data from the Thoth knowledge base, and any unknown packages will not be resolved.
A user can still input whatever they want (package and/or version) into the form fields. However, when it comes to resolving the packages, warnings will be put in place to notify users that the package requested is not available on Thoth. They will be presented with a link (below) to request the package be added to Thoth knowledge base.
https://github.com/thoth-station/support/issues/new?assignees=&labels=bug%2Ctriage&template=package_request.yaml
Optionally, we can use the PyPI endpoint as a peace of mind indicator. In the case of the data scientist, We can tell them: “Yes, that is a package on PyPI, but Thoth doesn't have knowledge of it.” This will add extra details to the warnings above and in the autocomplete dropdowns.
Additional context https://github.com/thoth-station/jupyterlab-requirements/pull/618#discussion_r808254446