search

thoth-station / jupyterlab-requirements

JupyterLab Extension for dependency management and optimization
GNU General Public License v3.0
16 stars 9 forks source link

fixed api bugs #636

Closed Gkrumbach07 closed 2 years ago

Gkrumbach07 commented 2 years ago

Related Issues and Dependencies

https://github.com/thoth-station/jupyterlab-requirements/issues/625 …

This introduces a breaking change

This Pull Request implements

fixed api param issues. added hardware inputs for advise

Description

sesheta commented 2 years ago

@Gkrumbach07: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/mypy d3d60750ec0ebbc2169b07ee68a340cdd4b8e1b4 link true /test thoth-mypy-py38

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Gkrumbach07 commented 2 years ago

/approve

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/jupyterlab-requirements/blob/master/OWNERS)~~ [Gkrumbach07,harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment