search

thoth-station / jupyterlab-requirements

JupyterLab Extension for dependency management and optimization
GNU General Public License v3.0
16 stars 9 forks source link

Fixed argparse #638

Closed Gkrumbach07 closed 2 years ago

Gkrumbach07 commented 2 years ago

Related Issues and Dependencies

https://github.com/thoth-station/jupyterlab-requirements/issues/632

This introduces a breaking change

This Pull Request implements

The issue was that argparse is intended for a command line, and when --help or -h was being called, a sys.exit command was being called. Normally is this is finer, but jupyter cells dont like being closed that way. So now there is a custom argparse instance with exit that doesnt include sys.exit

Description

Gkrumbach07 commented 2 years ago

/approve

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/jupyterlab-requirements/blob/master/OWNERS)~~ [Gkrumbach07] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment