search

thoth-station / jupyternb-build-pipeline

Openshift-pipelines and tekton based pipeline for packaging jupyternb in to image.
3 stars 6 forks source link

Add a build pipeline instance for aicoe-aiops/categorical-encoding pushing to Quay.io #4

Closed tumido closed 4 years ago

tumido commented 4 years ago

Related: https://github.com/aicoe-aiops/categorical-encoding/issues/2

Hi, we need help setting up a new pipeline for building an image from analytics repo, that would package it using s2i-custom-notebook base image and push it to public Quay.io. This image can't lend on the internal registry because it's public and has to be deployable as an example for Operate First - from anywhere, including outside RH firewall.

Can you please help us with that?

tumido commented 4 years ago

cc @harshad16

harshad16 commented 4 years ago

@tumido ,

if can you provide the details about the quay.io organization and repository to which image need to be build and push. we would use the aicoe-ci pipeline , as it has the feature to support what is required for this issue. i will send out a pull request to the categorical-encoding with updates needed.

Shreyanand commented 4 years ago

@tumido @harshad16 Meanwhile, should I remove the gitmodule and update the pipfile before we put it on quay?

harshad16 commented 4 years ago

@tumido @harshad16 Meanwhile, should I remove the gitmodule and update the pipfile before we put it on quay?

yes, +1 from my side

tumido commented 4 years ago

@harshad16 Ah! We can use AICoE-CI for this! :facepalm: You clever person, love it, yeah! :+1:

So, something like this in the source repo should be enough, correct?

# .aicoe-ci.yaml
...
build:
  base-image: quay.io/thoth-station/s2i-custom-notebook
  registry: quay.io
  registry-org: <ORG>
  registry-project: categorical-encoding
  registry-secret: <SECRET>

I can send the PR myself tomorrow, no need to bother you with it.

harshad16 commented 4 years ago

@tumido , few more keys are needed in the build. i had created a commit in here. please have a look https://github.com/harshad16/categorical-encoding/commit/f0ada27961b2e5e0c0188c06485415f7cced4675 if you would like we can have that in aicoe or any other quay repo

tumido commented 4 years ago

I think aicoe org is fitting for this. :+1: Nice, I like that, please open a PR and I promise to merge it soon (TM). :rocket:

I think we can include such config into the https://github.com/aicoe-aiops/project-template as well (maybe commented out, so we're not building every repo by default)...