search

thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

Bugfix: bump black version and fixing git repo typing bug #1038

Closed Gregory-Pereira closed 2 years ago

Gregory-Pereira commented 2 years ago

Related Issues and Dependencies

Related to thoth-station/s2i-generic-data-science-notebook issue 48, although this will not address that issue. This bugfix came up in the process of addressing that issue.

This introduces a breaking change

This Pull Request implements

The package _unicodefun was removed from click, and this did not work with Black v 22.0.1. Therefore I bumped the version of Black to the next version for which it would work (v22.3.0).

Additionally typing the self.__repo as git.Repo with no default value to address tests.

goern commented 2 years ago

what is the status of this? can we release it with the next milestone?

harshad16 commented 2 years ago

what is the status of this? can we release it with the next milestone?

It is under Review. The changes are not for release, it is a simple type fix. This a minor PR.

goern commented 2 years ago

@Gregory-Pereira is this good to approve?

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/kebechet/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment