thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

Kebechet manual update request did not update new available dependency #1039

Closed xtuchyna closed 2 years ago

xtuchyna commented 2 years ago

Bug description

Related issue https://github.com/thoth-station/mi-scheduler/issues/227

Tried to update new thoth-common dependency (https://github.com/thoth-station/common/issues/1256 ) by manually requesting kebechet,

Actual behavior

Request did not recognize new available dependency and was not successful (khebhut referenced previous release commit and closed the issue)

Expected behavior

Update new available common dependency to 0.36.2

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

goern commented 2 years ago

/sig user-experience

KPostOffice commented 2 years ago

@xtuchyna Are you sure a release was available on PyPI before you requested an update?

KPostOffice commented 2 years ago

If not could you please create a new issue requesting an update?

harshad16 commented 2 years ago

I verified the issue. It seems like just not connecting the right pr commit.

Opened a kebechet update issue https://github.com/thoth-station/mi-scheduler/issues/237, after the release of the new thoth-common v0.36.4 there was an auto update pr https://github.com/thoth-station/mi-scheduler/pull/238 with the right changes. however, the issue didn't tag it properly in the comments. https://github.com/thoth-station/mi-scheduler/issues/237#issuecomment-1216725695

This issue should be a low priority as it doesn't block the work. /priority important-longterm

harshad16 commented 2 years ago

/triage accepted

Assigning it to @shreekarSS

KPostOffice commented 2 years ago

Hmm, I think it is pointing to the intended commit. It is not meant to point to the merge commit but rather the commit for which the manager was run on. What should happen is that the update issue is commented on with a reference to the opened PR.