search

thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

[2pt] Use Kebechet Lock to avoid CMake dependency #1050

Closed KPostOffice closed 2 years ago

KPostOffice commented 2 years ago

Bug description

https://github.com/thoth-station/ray-ml-notebook/issues/5

Steps to Reproduce

Steps to reproduce the behavior:

  1. pull Kebechet image
  2. create Pipfile which matches https://github.com/thoth-station/ray-ml-notebook/blob/master/Pipfile
  3. run pipenv install --dev using pipfile inside container
  4. See error due to missing CMake

Actual behavior

Failure to lock/install dependencies

Expected behavior

Successfully locks despite missing build dependencies

Suggested Fix

Use pipenv lock instead of pipenv install in kebechet update manager.

KPostOffice commented 2 years ago

/good-first-issue

sesheta commented 2 years ago

@KPostOffice: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/thoth-station/kebechet/issues/1050): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
harshad16 commented 2 years ago

/triage accepted /sig stack-guidance /priority important-longterm