[3pt] Advise manager starting multiple advice requests and not closing them

codificat commented 2 years ago

Bug description

I requested an advice from Kebechet in https://github.com/thoth-station/ps-ip/issues/19 and it started 2 advise requests simultaneously.

Both of them completed without error.

Apparently, nothing else happened, and the issue is still open.

Steps to Reproduce

Steps to reproduce the behavior:

Have advise manager configured on your repo (e.g. https://github.com/thoth-station/ps-ip/blob/7fade66947eea249534c52f3789b560bd480bab4/.thoth.yaml#L22-L24)
Create an issue on the repo, with title: Kebechet Advise
Wait for the bot to act

Actual behavior

2 advice requests started, as per comments in the issue by the bot
issue still open, with no indication of what happened to the requested advice

Expected behavior

only 1 advice request started
issue gets updated with the result of the advice

Environment information

Side note: it might be good if Kebechet would report its version on the comments it generates.

It seems to be Kebechet v1.9.0: https://github.com/thoth-station/thoth-application/blob/aff38154c66efe09b1b25084e12083c04029a00a/kebechet/overlays/aws-prod/imagestreamtag.yaml#L11

codificat commented 2 years ago

/kind bug /sig user-experience

Also, as I think this impacts #1029, setting: /priority critical-urgent

codificat commented 2 years ago

Another example where the issue was not closed (or otherwise updated) after a successful advice request is https://github.com/thoth-station/python/issues/469 In that one, though, only one advice request was triggered

Gkrumbach07 commented 2 years ago

related: https://github.com/thoth-station/ps-nlp/issues/151 story points 3

shreekarSS commented 2 years ago

Feature request for Kebechet to report it's version https://github.com/thoth-station/kebechet/issues/1099

thoth-station / kebechet