thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

Update pipfile,Dockerfile and pipfile.lock files with cmake dependency #1100

Closed shreekarSS closed 2 years ago

shreekarSS commented 2 years ago

Signed-off-by: Shreekara sshreeka@redhat.com

Related Issues and Dependencies

Fixes: https://github.com/thoth-station/kebechet/issues/1072

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign sesheta after the PR has been reviewed. You can assign the PR to them by writing /assign @sesheta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/kebechet/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
KPostOffice commented 2 years ago

You shouldn't need to add cmake to the Pipfile. I think just having the cmake library installed in the container should be enough