call sync when generating dependency graph

thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date

24 stars 20 forks source link

call sync when generating dependency graph #1109

Closed KPostOffice closed 2 years ago

KPostOffice commented 2 years ago

otherwise arbitrary sub-dependencies will be found to satisfy the requirements

I noticed install was being called here which takes longer but also gets an arbitrary dependency graph. Sync will install deps directly from the lockfile

codificat commented 2 years ago

good find! /approve

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/kebechet/blob/master/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment