Closed codificat closed 1 year ago
/sig user-experience
I was able to dig a bit more here: I opened https://github.com/thoth-station/s2i-minimal-notebook/issues/575, which shows the same problem, and managed to capture the logs of the pod that ran the workflow.
The logs show 2 problems:
The cause of the failure to update the dependencies in that repo:
There are incompatible versions in the resolved dependencies:
traitlets>=4.2.0 (from jupyter-kernel-gateway==2.4.0->-r /tmp/pipenvj88ovu89requirements/pipenv-h51mgb6q-constraints.txt (line 10))
traitlets>=4.2.1 (from notebook==6.4.10->-r /tmp/pipenvj88ovu89requirements/pipenv-h51mgb6q-constraints.txt (line 4))
traitlets>=4.3.2 (from jupyterhub==1.5.0->-r /tmp/pipenvj88ovu89requirements/pipenv-h51mgb6q-constraints.txt (line 9))
traitlets~=5.0 (from jupyterlab-git==0.39.1->-r /tmp/pipenvj88ovu89requirements/pipenv-h51mgb6q-constraints.txt (line 2))
A failure when creating an issue:
github.GithubException.GithubException: 422
{"message": "Validation Failed", "errors": [{"resource": "Issue", "code": "custom", "field": "body", "message": "body is too long (maximum is 65536 characters)"}], ...
any updates on this?!
The attempt with these two lines is to limit the length of the issue. However it does so naively. These values have already been adjusted before. It might be worthwhile to try to come up with a more general solution.
Proposal: 1) Split data which is in the formatted string into two categories:
2) Format the string with the "required" information
3) Subtract len of intermediate string from 65000
. Divide by num of items in "other info". Truncate lengths before adding them to the final string
(can be improved a bit more by ordering "other info" from shortest to longest allowing extra free space to go to items in "other info" which are longer)
function signature:
def create_github_body(format_string: str, required_info: Dict[str, str], other_info: Dict[str, str], limit: int = 65000)
Do I read this correctly as /assign @KPostOffice /triage accepted /lifecycle active ? :smile:
Bug description
I requested Kebechet to update deps on https://github.com/thoth-station/s2i-minimal-notebook/issues/574 but nothing happened
Steps to Reproduce
Steps to reproduce the behavior:
Actual behavior
Nothing seems to happen. After 3 hours, no new PR comes in to the repo and no updates are received in the issue
Expected behavior
Environment information
Kebechet v1.10.3