Closed codificat closed 1 year ago
/sig user-experience
A suggestion from today's tech talk is: if we enable this, do it via a (new) configuration flag.
additional acceptance
additional acceptance
- [ ] should work on the OS climate demo repo
I tested on aicoe-osc-demo repo, able to create this PR https://github.com/shreekarSS/aicoe-osc-demo/pull/8 Issue raised https://github.com/os-climate/aicoe-osc-demo/issues/207
/triage accepted
/wg cnbi
Problem statement
When I use Kebechet's update manager, which uses
pipenv
to resolve dependencies, it refuses to invokepipenv lock
if myPipfile
contains references to local paths or pointers to git.For example, see https://github.com/AICoE/sefkhet-abwy/issues/192 where Kebechet says:
This is a bit frustrating, because
pipenv
would actually handle these.Continuing the example above, the sefkhet-abwy repository's
Pipfile
contains a git referenced package. Butpipenv lock
works:High-level Goals
As the update manager effectively uses
pipenv lock
to update dependencies, the goal of this request is to let the manager run in scenarios wherepipenv lock
runs.Proposal description
Do not block execution of
pipenv
resolution.Alternatives
The alternative of leaving the restriction (no git, no local) in place is consistent with the requirements of the thoth-advise manager.
However, as
pipenv
itself does not impose the restrictions that thoth advise does, the current behaviour makes it inconsistent withpipenv
.Additional context
I did a quick search on when the check for git references was introduced, and AFAICT this was added in #820 to address https://github.com/thoth-station/support/issues/20
Acceptance Criteria
Pipfile
orrequirements.txt
wherepipenv lock
does, without additional restrictions