search

thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

Remove checks for git and local path from pipfile #1140

Closed shreekarSS closed 1 year ago

shreekarSS commented 1 year ago

Signed-off-by: Shreekara sshreeka@redhat.com

Related Issues and Dependencies

Fixes: https://github.com/thoth-station/kebechet/issues/1125 …

KPostOffice commented 1 year ago

To give some context. @shreekarSS and I talked a bit about this and realized that the result from the function raising the issues in git repositories wasn't being used. This was the only reference to the code in the repo, so we decided it could be removed. The return statement to the get direct dependency version so that when old dependencies and new dependencies are calculated they don't throw error and instead report no differences in reported version.

codificat commented 1 year ago

/lgtm /approve

Thanks!

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/kebechet/blob/master/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment