search

thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

Create function which respects gh body limits #1146

Closed KPostOffice closed 2 years ago

KPostOffice commented 2 years ago

add function which allows for specifying required and optional info. Optional info will be truncated if body is > gh body limit

Related Issues and Dependencies

fixes: https://github.com/thoth-station/kebechet/issues/1122

This introduces a breaking change

sesheta commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

KPostOffice commented 2 years ago

This should be good 2 go, but I would appreciate a review.

KPostOffice commented 2 years ago

Seems like a great solution for the problem /lgtm

concerns for long term:

  • if the req_info can be in a greater len than limit, we arent checking that.
  • Even though we are trying to keep it under the limit, the limit seems to be still large comment maybe we should cut it into half, for readability purposes.

let's get this in and see if we have a readability issue.

  1. hopefully no one sees an entire back trace as "required" for a comment.
  2. often the info that is longest is hidden by a "read more"
KPostOffice commented 2 years ago

/approve

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/kebechet/blob/master/OWNERS)~~ [KPostOffice] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment