search

thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

make PR description independent of issue description #1171

Closed KPostOffice closed 1 year ago

KPostOffice commented 1 year ago

Issue description contains text which doesn't pertain to the PR, leaving it off should remove confusion without impacting overall readability; the triggering issue is already directly linked in the PR.

Signed-off-by: Kevin kpostlet@redhat.com

Related Issues and Dependencies

fixes: #1153

This introduces a breaking change

This Pull Request implements

I removed the code which replaces the issue body and uses it as the base text for the PR description. Instead replacing it with just a string based on the release type requested.

goern commented 1 year ago

/lgtm

KPostOffice commented 1 year ago

/lgtm

sesheta commented 1 year ago

@KPostOffice: you cannot LGTM your own PR.

In response to [this](https://github.com/thoth-station/kebechet/pull/1171#issuecomment-1315771715): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
KPostOffice commented 1 year ago

/approve

goern commented 1 year ago

/retest

goern commented 1 year ago

/assign @KPostOffice /unassign @goern

could you have a look at this?!

codificat commented 1 year ago

could you have a look at this?!

the pre-commit failure should be fixed by #1173 (once prow works again)

harshad16 commented 1 year ago

/test pre-commit

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/kebechet/blob/master/OWNERS)~~ [KPostOffice,harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment