thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

requirements manager with overlays #1180

Open KPostOffice opened 1 year ago

KPostOffice commented 1 year ago

Problem statement

Currently requirements manager only works if the pipenv files are in the root directory. Logic should be added — similar to that in adviser — to create requirements.txt files in overlay directories.

High-level Goals

requirements manager in project with overlays directory will create requirements.txt in overlay directories

Proposal description

Add a loop for a list of environments to the pipfile_requirements manager

Acceptance Criteria

Gkrumbach07 commented 1 year ago

@KPostOffice Does this issue solve the issue?

KPostOffice commented 1 year ago

It doesn't quite, though the changes should be minimal. This issue requires adding code to get the location of the requirements file somewhere around here. The basic idea is if overlays_dir is set then all the work should be done in <overlays_dir>/<environment_name> rather than the root directory

Gkrumbach07 commented 1 year ago

/triage accepted /priority backlog

acceptance criteria