search

thoth-station / kebechet

I'm Kebechet bot, goddess of freshness - I will keep your source code fresh and up-to-date
24 stars 20 forks source link

use consistent name for 'has_prev_release' #995

Closed KPostOffice closed 2 years ago

KPostOffice commented 2 years ago

Related Issues and Dependencies

Fixes: https://github.com/thoth-station/kebechet/issues/987

This introduces a breaking change

This Pull Request implements

Keeps the naming consistent for determining whether github repo has previous releases.

KPostOffice commented 2 years ago

@fridex The name of the boolean flipped its purpose, but it wasn't inverted when it was passed to the function. So in the function it was doing the exact opposite of its intention

fridex commented 2 years ago

@fridex The name of the boolean flipped its purpose, but it wasn't inverted when it was passed to the function. So in the function it was doing the exact opposite of its intention

Oh, I see. Nice catch, thanks for the fix 👍🏻

/approve

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/kebechet/blob/master/OWNERS)~~ [fridex] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment