thoth-station / management-api

An API service used for administration of deployed Thoth
GNU General Public License v3.0
3 stars 11 forks source link

Automatic update of base-image in CI #908

Closed sesheta closed 2 years ago

sesheta commented 2 years ago

Automatic update of base-image in CI.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sefkhet-abwy[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/management-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sefkhet-abwy[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/management-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sefkhet-abwy[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/management-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
goern commented 2 years ago

/test all

VannTen commented 2 years ago

/retest aicoe-ci/build-check

sesheta commented 2 years ago

@VannTen: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/thoth-station/management-api/pull/908#issuecomment-1199071554): >/retest aicoe-ci/build-check Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
VannTen commented 2 years ago

/test all

VannTen commented 2 years ago

@goern @harshad16

I think this PR (more precisely, its branch is causing the other to fail) See https://tekton.operate-first.cloud/#/namespaces/opf-ci-pipelines/pipelineruns/aicoe-pipelinerun-0868e1af-f680-4d64-ade8-a07d556a8233?pipelineTask=base-image-update-run&step=rebase

+ git config --local user.email ***@***.***
+ git config --local user.name sesheta
+ git remote set-url origin ***@***.***:thoth-station/management-api.git
+ git checkout -b aicoe-ci-base-image-updater
Switched to a new branch 'aicoe-ci-base-image-updater'
+ export 'GIT_SSH_COMMAND=ssh -i /tekton/home/.ssh/id_rsa -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no'
+ GIT_SSH_COMMAND='ssh -i /tekton/home/.ssh/id_rsa -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no'
+ git add .
+ git commit -m ':ship: Bump up base image initialized in CI.'
[aicoe-ci-base-image-updater ca9b9aa] :ship: Bump up base image initialized in CI.
 1 file changed, 1 insertion(+), 1 deletion(-)
+ git pull --rebase origin master
Warning: Permanently added 'github.com,140.82.113.4' (ECDSA) to the list of known hosts.
From github.com:thoth-station/management-api
 * branch            master     -> FETCH_HEAD
Current branch aicoe-ci-base-image-updater is up to date.
+ git push -f origin aicoe-ci-base-image-updater
Warning: Permanently added 'github.com,140.82.113.4' (ECDSA) to the list of known hosts.
remote: error: GH006: Protected branch update failed for refs/heads/aicoe-ci-base-image-updater.        
remote: error: Cannot force-push to this protected branch        
To github.com:thoth-station/management-api.git
 ! [remote rejected] aicoe-ci-base-image-updater -> aicoe-ci-base-image-updater (protected branch hook declined)
error: failed to push some refs to 'github.com:thoth-station/management-api.git'

Should we un protect the branch or use a merge instead of rebase (I'd vote for the latter) ?

harshad16 commented 2 years ago

we should update the prow config, to unprotect such branch. will do that thanks.