search

thoth-station / management-api

An API service used for administration of deployed Thoth
GNU General Public License v3.0
3 stars 11 forks source link

:recycle: Correct the error type for exception handle in get_log #929

Closed harshad16 closed 1 year ago

harshad16 commented 1 year ago

Correct the error type for exception handle in get_log Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: https://github.com/thoth-station/management-api/issues/920

Description

The exception would be handled properly and give 404 not found, instead of 500 internal error.

harshad16 commented 1 year ago

Tested Locally: Screenshot from 2022-10-13 14-45-18

harshad16 commented 1 year ago

/approve Merging for new release. Tested it works.

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/management-api/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment