search

thoth-station / meteor-operator

Project Meteor Operator for OpenShift
GNU General Public License v3.0
4 stars 11 forks source link

refactore PipelineRun Parameter creation #128

Closed goern closed 1 year ago

goern commented 1 year ago

Depends-On: #115

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from goern by writing /assign @goern in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/meteor-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VannTen commented 1 year ago

Can we take out the rename to CRE (already has #115 ) and the config for golangci-lint in separate PRs ?

goern commented 1 year ago

reverted golangci config, and 2a2cf77 should be part of #115

VannTen commented 1 year ago

This has been superseded, right ?

goern commented 1 year ago

very true! thx for the reminder!

/close

sesheta commented 1 year ago

@goern: Closed this PR.

In response to [this](https://github.com/thoth-station/meteor-operator/pull/128#issuecomment-1400110336): >very true! thx for the reminder! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.