thoth-station / meteor-operator

Project Meteor Operator for OpenShift
GNU General Public License v3.0
4 stars 11 forks source link

Refactor cnbi reconcile loop and conditions #129

Closed VannTen closed 1 year ago

VannTen commented 1 year ago

Main point is to fix the flake evidenced by #127

There is also a bunch of refactor, see messages commits.

@goern : regarding using the upstream conditions, I think it's worth it (less code, less TCO) but wdyt ? The commit can get out.

goern commented 1 year ago

/lgtm /approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/meteor-operator/blob/main/OWNERS)~~ [goern] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
goern commented 1 year ago

/retest all

sesheta commented 1 year ago

@goern: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/thoth-station/meteor-operator/pull/129#issuecomment-1318393374): >/retest all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
goern commented 1 year ago

/test pre-commit

goern commented 1 year ago

/test pre-commit

VannTen commented 1 year ago

Is there something wrong with prow ? The pr is marked "Good to be merged" in tide but apparently it doesn't get merged ? @harshad16 @goern

harshad16 commented 1 year ago

Its in the merge pool, would be merged in few mins prow might be taking it coffee break :coffee: :smile:

harshad16 commented 1 year ago

Merging this as it seems to be blocked somewhere in tide though there is no info on the log.