Closed VannTen closed 1 year ago
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: goern
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest all
@goern: The /retest
command does not accept any targets.
The following commands are available to trigger required jobs:
/test make-test
/test pre-commit
Use /test all
to run all jobs.
/test pre-commit
/test pre-commit
Is there something wrong with prow ? The pr is marked "Good to be merged" in tide but apparently it doesn't get merged ? @harshad16 @goern
Its in the merge pool, would be merged in few mins prow might be taking it coffee break :coffee: :smile:
Merging this as it seems to be blocked somewhere in tide though there is no info on the log.
Main point is to fix the flake evidenced by #127
There is also a bunch of refactor, see messages commits.
@goern : regarding using the upstream conditions, I think it's worth it (less code, less TCO) but wdyt ? The commit can get out.