search

thoth-station / meteor-operator

Project Meteor Operator for OpenShift
GNU General Public License v3.0
4 stars 11 forks source link

Use Subscription object to install pre-requisisites (Pipelines, Cert manager) #134

Closed VannTen closed 1 year ago

VannTen commented 1 year ago

(Only works for Openshift)

VannTen commented 1 year ago

idk if we should trigger the deployment of cert-manager on deploy. if we consider make deploy a dev time tool its ok.

That was a typo, the intention is to have a simple dev tools to deploy the prerequisites. I removed the deploy -> prerequisite relation.

VannTen commented 1 year ago

On Thu, Nov 17, 2022 at 02:51:27AM -0800, Pep Turró Mauri wrote:

The problem with manual approval is that it requires intervention - that's why I mentioned automatic above... but you are right I think: we can't pin and have it automatic at the same time.

Are we ok with that manual approval?

I don't think that's much of a problem. And yeah we can't pin without setting the upgrade to Manual anyway.

I'm not sure, but I would suppose that applying the Subscription object with a different startingCsv should work as well.

VannTen commented 1 year ago

I'd start with openshift-pipelines 1.6.4 and cert-manager 1.9.1 for now, we can change that later. Wdyt @goern @codificat ? (Based on pep reports on the RHODS cluster)

VannTen commented 1 year ago

OLM does not provide a way, AFAICS, to pin to a specific version (startingCSV is only the starting point of the installPlan). Besides, the Manual approval is painful, there isn't a dedicated cli command (need to patch a spec field) and the name of the installPlan is random.

I think the best we can do is use the channel as major versions, and stick to automatic approval. wdyt ?

VannTen commented 1 year ago

1.7 is the oldest channel available on quicklab clusters from what I can see

codificat commented 1 year ago

I think the best we can do is use the channel as major versions, and stick to automatic approval. wdyt ?

Makes sense, thanks! /lgtm /approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/meteor-operator/blob/main/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment