thoth-station / meteor-operator

Project Meteor Operator for OpenShift
GNU General Public License v3.0
4 stars 11 forks source link

Fix import pipeline parameter names and validate task reference #151

Closed codificat closed 1 year ago

codificat commented 1 year ago

Fixes: #145

The cre-import pipeline parameters did not match what the meteor-operator controller is passing (e.g. url vs baseImage).

We could change the controller or the pipelines, but thinking in consistency within the controller and possible generalizations in pipeline invocation there, this PR changes the pipeline parameter names to match what the controller sets.

Also fixing a task reference that did not match the name of the task: [byon-]validate-jupyterhub-image

VannTen commented 1 year ago

Honestly I was just doing a "literal update" here (byon -> CNBi -> CRE)

Looking closer now, according to Kubernetes' recommended labels it seems this should be part-of instead of created-by I think. And for the value, it should probably be meteor-operator.

Well, since it does not seem we have that many instance of that labels we might as well include that change in this PR, I think.

EDIT: beat me to it ^

VannTen commented 1 year ago

/lgtm

codificat commented 1 year ago

/approve

to get that in

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/meteor-operator/blob/main/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 1 year ago

/hold

codificat commented 1 year ago

Sorry, I noticed last minute that a change to the manager kustomization file (image ref from local testing) had slipped.

I removed that now, ready for re-lgtm. /unhold

goern commented 1 year ago

/lgtm