Closed codificat closed 1 year ago
Honestly I was just doing a "literal update" here (byon -> CNBi -> CRE)
Looking closer now, according to Kubernetes' recommended labels it seems this should be
part-of
instead ofcreated-by
I think. And for the value, it should probably bemeteor-operator
.
Well, since it does not seem we have that many instance of that labels we might as well include that change in this PR, I think.
EDIT: beat me to it ^
/lgtm
/approve
to get that in
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: codificat
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold
Sorry, I noticed last minute that a change to the manager kustomization file (image ref from local testing) had slipped.
I removed that now, ready for re-lgtm. /unhold
/lgtm
Fixes: #145
The
cre-import
pipeline parameters did not match what the meteor-operator controller is passing (e.g. url vs baseImage).We could change the controller or the pipelines, but thinking in consistency within the controller and possible generalizations in pipeline invocation there, this PR changes the pipeline parameter names to match what the controller sets.
Also fixing a task reference that did not match the name of the task:
[byon-]validate-jupyterhub-image