thoth-station / meteor-operator

Project Meteor Operator for OpenShift

GNU General Public License v3.0

4 stars 11 forks source link

add odh label #155

Closed goern closed 1 year ago

goern commented 1 year ago

As Gage pointed out in chat, we need to add another label 'opendatahub.io/notebook-name: true' to the imagestream created by CRE

/kind feature /wg cre /priority critical-urgent

goern commented 1 year ago

/project Planning Board

goern commented 1 year ago

124 might be related and fix this

harshad16 commented 1 year ago

Already being added on built image: https://github.com/thoth-station/meteor-operator/blob/a60a8ac5f4bdc0db7964b53c6cf267ec02fbf270/pipelines/pipelines/cre-package-list.yaml#L94

Missing in import:

[] https://github.com/thoth-station/meteor-operator/blob/a60a8ac5f4bdc0db7964b53c6cf267ec02fbf270/pipelines/pipelines/cre-import.yaml#L63

codificat commented 1 year ago

Actually, on import this label is also added - but only after the validation of the image succeeds: https://github.com/thoth-station/meteor-operator/blob/a60a8ac5f4bdc0db7964b53c6cf267ec02fbf270/pipelines/pipelines/cre-import.yaml#L174-L177