Closed codificat closed 1 year ago
/wg cre /priority important-soon
Is the pipeline results used somewhere ? Can't figure out what should be there (and blame is not helpful, too much renaming)
Is the pipeline results used somewhere ?
It isn't.
Can't figure out what should be there (and blame is not helpful, too much renaming)
Yep. To hopefully clarify a bit: the pipeline and tasks came mostly "as is" from meteor's jupyterhub pipelines, as hosted in the helm charts repo
There are a few things we don't use at the moment: results, owner ref, and namespace extraction.
As an alternative, I also have #152 as a possible alternative (== PackageList + a PEP 517 build and install).
As an alternative, I also have #152 as a possible alternative (== PackageList + a PEP 517 build and install).
Apologies if I am missing something here, but I believe #152 is complementary rather than alternative.
This intend to implement a git-repo pipeline which would not depend on an aicoe-ci.yaml file at the repository root.
Basic question about the scope here, just want to clarify.
The proposal here would aim at building images for git repos that host Python packages, correct? And (probably) not cover repos that contain (mostly) jupyter notebooks, right?
I'm asking because I believe CNBi / CRE's main use case is for repos where (most of) the content is "notebook-type" rather than Python packages.
On Mon, Jan 16, 2023 at 04:58:02AM -0800, Pep Turrรณ Mauri wrote:
As an alternative, I also have #152 as a possible alternative (== PackageList + a PEP 517 build and install).
Apologies if I am missing something here, but I believe #152 is complementary rather than alternative.
This intend to implement a git-repo pipeline which would not depend on an aicoe-ci.yaml file at the repository root.
Basic question about the scope here, just want to clarify.
The proposal here would aim at building images for git repos that host Python packages, correct? And (probably) not cover repos that contain (mostly) jupyter notebooks, right?
I'm asking because I believe CNBi / CRE's main use case is for repos where (most of) the content is "notebook-type" rather than Python packages.
So the current gitRepo is for git repos containing notebooks in Python ? I had not get that ^^
Bug description
The current version of the
cre-gitrepo
pipeline (that implements theGitRepository
build type) is not working.Steps to Reproduce
Steps to reproduce the behavior:
GitRepository
(for example, the one in config/samples)Actual behavior
Expected behavior
The PipelineRun created for the git repo CRE works.
Environment information
meteor-operator v0.2.1
Additional context
Noticed this while reviewing https://github.com/thoth-station/odh-dashboard/pull/14
This is not a use case in the initial CNBi functionality, and therefore it's optional in that sense for the initial version.