Inconsistent phase between CRE and ImageStream

[codificat]

Bug description

The Phase of a custom environment gets inconsistent between a CustomRuntimeEnvironment and associated ImageStream.

Steps to Reproduce

Steps to reproduce the behavior:

1. Create a CRE of type import
2. Set the image to import to quay.io/repository/thoth-station/elyra-aidevsecops-training:v0.14.1. That image does not meet the requirements
3. Let the associated PipelineRun complete

Actual behavior

$ oc get cre cre-1673945925026 -o jsonpath='{.status.phase}'
Succeeded

$ oc describe is cre-cre-1673945925026-import | grep phase=
            opendatahub.io/notebook-image-phase=Failed

Expected behavior

The phase information between CRE and ImageStream should match.

Environment information

meteor-operator v0.2.1

Additional context

Logs for the pipelinerun for the example image import above, where the import is marked as failed because it doesn't meet the expected requisites:

[validate : get-package-versions] Analyzing image:
[validate : get-package-versions]     Python:             3.8.6
[validate : get-package-versions]     Python packages:    boto3==1.18.42 matplotlib==3.4.3 tensorflow==2.6.0 thamos==1.18.1
[validate : get-package-versions]     R (optional):       Not available
[validate : get-package-versions]     RStudio (optional): Not available

[validate : minimal-requirements] Validating minimal requirements:
[validate : minimal-requirements]     Python >= 3.8.0 ✅
[validate : minimal-requirements]     'jupyterhub' package is present ❌
[validate : minimal-requirements]     'jupyterlab' package is present ❌
[validate : minimal-requirements]     $HOME is writeable ✅
[validate : minimal-requirements]     start-singleuser.sh is present  ❌
[validate : minimal-requirements]     start-singleuser.sh must execute 'jupyter'  ❌
[validate : minimal-requirements]     start-singleuser.sh must start 'labhub' environment  ⚠
[validate : minimal-requirements]     start-singleuser.sh must accept runtime args or pass a config file  ⚠

[update-imagestream : oc] Updating image stream:
[update-imagestream : oc]   Name:       cre-cre-1673945925026-import
[update-imagestream : oc]   Namespace:  aicoe-meteor
[update-imagestream : oc] 
[update-imagestream : oc]   Image tag:           v0.14.1
[update-imagestream : oc]   Phase:               Failed
[update-imagestream : oc]   Messages:            [{"severity":"error","message":"Missing 'jupyterhub' python package"},{"severity":"error","message":"Missing 'jupyterlab' python package"},{"severity":"error","message":"start-singleuser.sh script must be present in /opt/app-root/bin:/opt/app-root/src/.local/bin/:/opt/app-root/src/bin:/opt/app-root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin and executable"},{"severity":"error","message":"start-singleuser.sh script took too long to call 'jupyter labhub'"}]
[update-imagestream : oc]   Visibility:          false
[update-imagestream : oc]   Software:            [{"name":"Python","version":"3.8.6"}]
[update-imagestream : oc]   Python dependencies: [{"name": "boto3", "version": "1.18.42", "visible": true}, {"name": "matplotlib", "version": "3.4.3", "visible": true}, {"name": "tensorflow", "version": "2.6.0", "visible": true}, {"name": "thamos", "version": "1.18.1", "visible": true}]
[update-imagestream : oc] 
[update-imagestream : oc] imagestream.image.openshift.io/cre-cre-1673945925026-import patched
[update-imagestream : oc] imagestream.image.openshift.io/cre-cre-1673945925026-import annotated

[VannTen]

I think we're getting rid of the Phase in the CRE status ( #168 / #130 )

[codificat]

Yes - but it's currently in use by the dashboard - both in the CRE status and ImageStream annotations

[goern]

/wg cre