thoth-station / mi

an experiment on Source Operation Metrics
GNU General Public License v3.0
6 stars 10 forks source link

Implement Kebechet Managers SLO/SLI metrics #572

Closed xtuchyna closed 1 year ago

xtuchyna commented 2 years ago

Problem statement

Related to #560 (section Managers SLO/SLI)

As a maintainer, I would like to have a look at dashboard with all Kebechet metrics

so that I can see which managers are used and performing well, which needs attention (slow responding time, critical number of rejected requests, and etc.) and which managers are not used (so even if they need attention, they can be of a low-priority).

Acceptance criteria

Create following metrics

For

Extension

and also

UPDATE after discussion (https://docs.google.com/document/d/1jz4j07Q8gkv9H-23BgOp_4qN3uI29JsuP-_kTKEj-e8/edit#bookmark=id.66cutwjvs6o2):

Additional SLI metrics:

Additional SLO metrics:

goern commented 2 years ago

@xtuchyna ping

xtuchyna commented 2 years ago

@goern have a look at https://github.com/thoth-station/mi/pull/574#issuecomment-1190324481 :slightly_smiling_face:

xtuchyna commented 2 years ago

@goern @Gkrumbach07 so currently the update advise and version managers are implemented (look at PR to see data files example). I suggest splitting the Issue so we can track the features better. WDYT?

goern commented 2 years ago

@xtuchyna ja, pls go ahead and split this issue

goern commented 2 years ago

/sig user-experience

Gkrumbach07 commented 1 year ago

Condensing issue due to inactivity The following metrics for version, update, and advise managers are added:

closing this issue and propagating uncompleted issues to parent EPIC /close

sesheta commented 1 year ago

@Gkrumbach07: Closing this issue.

In response to [this](https://github.com/thoth-station/mi/issues/572#issuecomment-1409151221): >**Condensing issue due to inactivity** >The following metrics for version, update, and advise managers are added: >- advise > - repository_usage_count > - total_source_code_lines_changed_by_bot > - percent_source_code_changes_by_bot >- version > - repository_usage_count >- update > - repository_usage_count > - total_source_code_lines_changed_by_bot > - percent_source_code_changes_by_bot >- repositories_missing_issue_metric >- repositories_missing_pull_request_metric > >closing this issue and propagating uncompleted issues to parent EPIC >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.