search

thoth-station / mi

an experiment on Source Operation Metrics
GNU General Public License v3.0
6 stars 10 forks source link

Kebechet SLI/SLO metrics [update, advise, version] #574

Closed xtuchyna closed 2 years ago

xtuchyna commented 2 years ago

Related Issues and Dependencies

Closes #572 #598 #599 #600

This introduces a breaking change

This should yield a new module release

This Pull Request implements

Currently the data is stored as a csv in following format (tested only on 3 repositories thoth-station/mi-scheduler,thoth-station/mi,thoth-station/thoth-github-action, with update manager left out)

Kebechet SLI/SLO metrics

>>> sli_slo_metrics.head() # accessing as pandas dataframe
                        advise  version update  overall_repositories
repository_usage_count       3        3      3                     3

at location ./srcopsmetrics/metrics/kebechet_sli_slo.csv

Kebechet usage indicators

34,thoth-station/thoth-github-action,advise,1655453223
35,thoth-station/thoth-github-action,advise,1655979995
51,thoth-station/thoth-github-action,version,1655194485
40,thoth-station/thoth-github-action,version,1654004461
36,thoth-station/thoth-github-action,version,1653991518
0,thoth-station/mi,advise,1571990467
1,thoth-station/mi,advise,1574353722

at location ./srcopsmetrics/metrics/kebechet_sli_slo.csv

Example file

sli/slo metrics file

kebechet_sli_slo.csv

usage count file

kebechet_usage_counts.csv

xtuchyna commented 2 years ago

/hold

xtuchyna commented 2 years ago

/cc @goern

xtuchyna commented 2 years ago

Looking at the original issue, it has many goals and extensions, so it is not clear what follows. What should we prioritize and do next, should we split the Issue or just complete it in this PR (which could be a blocker for basic metrics that are already implemented) ? @goern @Gkrumbach07 @codificat

xtuchyna commented 2 years ago

Added usage indicators

xtuchyna commented 2 years ago

Closes #598 #599 #600

xtuchyna commented 2 years ago

/unhold

xtuchyna commented 2 years ago

/cc @Gkrumbach07 @goern

goern commented 2 years ago

is this ready to merge? I didnt have a look at the code, but would like to see what the metrics report or dashboard looks like.

Gkrumbach07 commented 2 years ago

The usage metrics look good. Did you plan on exporting a aggregate output of each repos usage, or will that be the job of the dashboard? @xtuchyna

xtuchyna commented 2 years ago

@Gkrumbach07 we can definitely add it to the SLI/SLO dataframe or create an aggregate output on its own

xtuchyna commented 2 years ago

@goern all the data file examples this functionality generates are attached to the PR description, and yes I feel like this can be merged

xtuchyna commented 2 years ago

/approve

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xtuchyna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/mi/blob/master/OWNERS)~~ [xtuchyna] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment