search

thoth-station / mi

an experiment on Source Operation Metrics
GNU General Public License v3.0
6 stars 10 forks source link

Mi fixes #609

Closed Gkrumbach07 closed 2 years ago

Gkrumbach07 commented 2 years ago

Related Issues and Dependencies

related to: https://github.com/thoth-station/mi/issues/572

This introduces a breaking change

This Pull Request implements

Completes:

changes to the source code (e.g. update and version managers), furthermore for specific managers specific files (e.g. update manager and contributor comparison - how much did bot commit to the Pipfile in opposed to how much did contributor)

Description

Added fail safes for missing env vars. Added a SLI. Added catches to missing data when completing SLI/SLO

xtuchyna commented 2 years ago

Hey @Gkrumbach07 , I've suggested some changes, let me know what you think!

Gkrumbach07 commented 2 years ago

Hey @Gkrumbach07 , I've suggested some changes, let me know what you think!

Sorry for the delay, I will get to the changes today.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xtuchyna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/mi/blob/master/OWNERS)~~ [xtuchyna] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment