search

thoth-station / prescriptions-refresh-job

A periodic job to refresh Thoth's prescriptions
GNU General Public License v3.0
0 stars 7 forks source link

Remove destination table from BigQuery config #171

Closed mayaCostantini closed 2 years ago

mayaCostantini commented 2 years ago

This introduces a breaking change

This should yield a new module release

This Pull Request implements

Remove BigQuery destination table in pypi-downloads handler. Writing to a destination table does not seem to have any utility here and might be the source of a lot of traffic generated on the BigQuery API (~6000 calls to the google.cloud.bigquery.v2.JobService.InsertJob API method).

mayaCostantini commented 2 years ago

@codificat thanks for the review, I updated the PR description and squashed the commits

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/prescriptions-refresh-job/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment